On Thu, Jun 02, 2016 at 06:34:53PM +0800, Benli Ye wrote: > Add support to export tunnel information for flow-based IPFIX.
Thanks for the patch! I believe that this changes the NXAST_SAMPLE action in a backward-incompatible way. We never do that, because it breaks any software that already uses the action. Usually, if the need to change an action comes up, we add a new version of the action. For example, in this case, you might add an NXAST_SAMPLE2 action that has the new behavior (if there is a better name than NXAST_SAMPLE2, please use it). In dpif_ipfix_flow_sample(), I am not sure that it makes sense to exclude BFD packets. For bridge-level sampling, the controller cannot otherwise exclude packets from sampling, but with flow-level sampling, the controller can exclude sampling any packets it likes, with appropriate use of flows. Also, the switch processes BFD without packets going through the flow table anyway, so I'm not sure that this code will do anything. Please write comments as full sentences that begin with a capital letter and end in a period, e.g. here in adjust_sample_action(): + /* set_tunnel action should be in front + * of sample action which contains OVS_USERSPACE_ATTR_EGRESS_TUN_PORT + * attribute */ Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
