On Thu, May 26, 2016 at 10:02:54AM +0100, Markos Chandras wrote:
> The 'date' and 'time' arguments are normally being set by
> 'ovs_set_program_name' using __DATE__ and __TIME__. However, this
> breaks reproducible builds since even without any changes in the
> toolchain, build system etc, the end binary will still differ in
> that regard. This is also visible when building with -Wdate-time:
>
> utilities/ovs-dpctl.c:61:29: warning: macro "__DATE__" might prevent
> reproducible builds [-Wdate-time]
> set_program_name(argv[0]);
> ^
>
> and it's also something that triggers the following warning in the
> openSUSE OBS builds:
>
> [...]
> openvswitch.x86_64: W: file-contains-date-and-time /usr/bin/ovs-ofctl
> openvswitch.x86_64: W: file-contains-date-and-time /usr/bin/ovs-appctl
> Your file uses __DATE and __TIME__ this causes the package to rebuild
> when not needed
> [...]
>
> This patch drops these two arguments from ovs_set_program_name__ and
> renames the function to ovs_set_program_name dropping the previous
> preprocessor macro in the process.
>
> This finally removes the remaining references to __DATE__ and __TIME__
> from the sources which is something that has already been done in
> commit 26bfaeaa9687 ("Stop using __DATE__ and __TIME__ in startup
> string.") for the kernel datapath.
>
> Cc: Jan Engelhardt <jeng...@inai.de>
> Signed-off-by: Markos Chandras <mchand...@suse.de>
Applied, thanks!
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
