On Fri, May 20, 2016 at 11:21:32AM +0200, Quentin Monnet wrote:
> From: Ding Zhi <[email protected]>
>
> Running `ovs-appctl stp/tcn ovsbr0` tries to lock `mutex` in
> `stp_unixctl_tcn()`; but `mutex` is initialized only once in
> `stp_create()`. As a result, the command crashes if STP has not been
> enabled on the switch yet.
>
> This commit ensures that the `stp/tcn` command is registered only after
> `mutex` is initialized (and thus cannot be called at all if STP has not
> been enabled).
>
> Signed-off-by: Ding Zhi <[email protected]>
> Signed-off-by: Liu Xiaofeng <[email protected]>
> Signed-off-by: Quentin Monnet <[email protected]>
Thanks for the bug fix!
I think it's quite strange for stp/tcn to appear in the list of commands
only when STP has been enabled, so I'm suggesting an alternative patch:
http://openvswitch.org/pipermail/dev/2016-May/071396.html
Does it also solve the problem?
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
