On Fri, May 06, 2016 at 08:16:55PM +0530, Numan Siddique wrote:
> OVN implements a native DHCP support which caters to the common
> use case of providing an IP address to a booting instance by
> providing stateless replies to DHCP requests based on statically
> configured address mappings. To do this it allows a short list of
> DHCP options to be configured and applied at each compute host
> running ovn-controller.
> 
> A new table 'Subnet' is added in OVN NB DB to store the DHCP options.
> 
> A logical flow is added for each logical port to handle DHCP packets
> using the 'dhcp_offer' action if the CMS has defined DHCP options
> in the 'Subnet' column.
> 
> Signed-Off-by: Numan Siddique <nusid...@redhat.com>

I get a compiler warning:
        ../TESTS/test-ovn-dhcp.c:220:28: error: cast from 'const char *' to 
'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 
[-Werror,-Wcast-align]
for this:
        uint32_t cookie = *(uint32_t *)footer;
Probably you should use get_unaligned_be32(), also ovs_be32 since as
sparse says:
        ../tests/test-ovn-dhcp.c:221:28: warning: restricted ovs_be32 degrades 
to integer

This otherwise seems pretty straightforward once patch 1 is ready.
Sweet!

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to