On Wed, May 04, 2016 at 01:08:13PM -0700, Jarno Rajahalme wrote:
> There is no need to set the revalidate flag after each flow mod
> separately, as we can do it once after the whole transaction is
> finished. It is not done at all if the transaction fails.
>
> In the successful case this change makes no functional difference,
> since the revalidation thread is triggered by the main thread only
> after a bundle transaction has been fully processed.
>
> Signed-off-by: Jarno Rajahalme <ja...@ovn.org>
It's not really obvious from the comment on set_tables_version that it
will be called after each set of flow table changes. I guess that's a
good inference for the educated reader to draw, but it would even nicer
to explain it.
It would be nice to have a blank line after the set_tables_version
declaration here, while you're in there anyhow:
/* Sets the current tables version the provider should use for classifier
* lookups. */
void (*set_tables_version)(struct ofproto *ofproto, cls_version_t version);
/* ## ---------------- ## */
/* ## ofport Functions ## */
/* ## ---------------- ## */
Acked-by: Ben Pfaff <b...@ovn.org>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
