Hi Aaron, one more comment inline The rest of the series looks good to me
Thanks, Daniele On 26/04/2016 12:42, "Aaron Conole" <acon...@redhat.com> wrote: >A previous patch introduced the ability to pass arbitrary EAL command >line options via the dpdk_extras database entry. This commit enhances >that by warning the user when such a configuration is detected and >prefering the value in the database. > >Suggested-by: Sean K Mooney <sean.k.moo...@intel.com> >Signed-off-by: Aaron Conole <acon...@redhat.com> >Tested-by: Sean K Mooney <sean.k.moo...@intel.com> >Tested-by: Kevin Traynor <kevin.tray...@intel.com> >Acked-by: Panu Matilainen <pmati...@redhat.com> >Acked-by: Flavio Leitner <f...@sysclose.org> >--- >Previous: http://openvswitch.org/pipermail/dev/2016-April/069032.html > >v12: >* No change > > lib/netdev-dpdk.c | 66 +++++++++++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 55 insertions(+), 11 deletions(-) > >diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c >index d676a3e..353954d 100644 >--- a/lib/netdev-dpdk.c >+++ b/lib/netdev-dpdk.c >@@ -2774,6 +2774,17 @@ dpdk_option_extend(char ***argv, int argc, const char >*option, > newargv[argc+1] = xstrdup(value); > } > >+static char ** >+move_argv(char ***argv, size_t cur_size, char **src_argv, size_t src_argc) >+{ >+ char **newargv = grow_argv(argv, cur_size, src_argc); >+ while (src_argc--) { >+ newargv[cur_size+src_argc] = src_argv[src_argc]; >+ src_argv[src_argc] = 0; Minor nit: sparse complains about this, '0' should be 'NULL' _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
