On Sun, Apr 03, 2016 at 09:49:03PM -0400, Ramu Ramamurthy wrote:
> Move the function extract_lport_addresses to a file
> in ovn/lib since that function can be used by ovn-controller also
> to parse addresses stored in the mac column of the
> port_binding table. Currently that function is used only
> in ovn_northd.
> 
> Signed-off-by: Ramu Ramamurthy <ramu.ramamur...@us.ibm.com>

Please add the standard license notice at the top of each of the new
files.

Function-level comments go on function definitions, not their header
file prototypes.

The comment
+/* contains ovn utility functions */
isn't very useful and I'd recommend deleting it.

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to