Please limit the subject to about 65 characters. This is mentioned in
CONTRIBUTING.md.
Please don't indent the commit message.
On Fri, Apr 01, 2016 at 03:28:11PM -0700, ngh...@us.ibm.com wrote:
> Configure ovn-controller SB probe_timer on the fly and disable other unix
> domain socket based connections
>
> There are four sessions established from ovn-controller to the following:
> OVN Southbound — JSONRPC based
> Local ovsdb — JSONRPC based
> Local vswitchd — openflow based from ofctrl
> Local vswitchd — openflow based from pinctrl
>
> All of these sessions have their own probe_interval, and currently only
> one
> [SB] of them can be configured using ovn-vsctl command, and that is not
> effective on the fly —in other words, ovn-controller has to be restarted
> to
> use that probe_timer value. For the rest, probe timers need to be disabled
> as they are over unix domain socket. ovsdb was already doing that.
>
> This patch will take care of disabling probe timer for ofctrl and pinctrl,
> and make sure SB timer changes take effect on the fly.
>
> Using NB database’s external-id, SB timer settings are stored, here is
> how to
> set it:
> ovs-vsctl --no-wait set open_vswitch . \
> external-ids:ovn-remote-probe-interval=7000
>
> Signed-off-by: Nirapada Ghosh <ngh...@us.ibm.com>
This function should not exist. Instead, use the existing function
stream_or_pstream_needs_probes():
> +/* For unix domain socket, target starts with "unix:", the following
> function returns
> + * True when the argument indicates that it is unix domain socket
> + */
> +static inline bool
> +unix_domain_socket(const char *target)
> +{
> + return (!(strncmp(target,"unix:",5)));
> +}
> +
There is no need log for this, it just pollutes the log:
> + VLOG_INFO("connected with probe-interval %d", rc->probe_interval);
Please read CodingStyle.md carefully and adjust the code that you write
to honor the style described there. I see several inconsistencies that
distract the reader.
Thanks,
Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
