Thanks. I will put it in separate script. On Thu, Mar 31, 2016 at 10:21 AM, Ben Pfaff <b...@ovn.org> wrote:
> On Wed, Mar 30, 2016 at 08:23:33AM -0700, William Tu wrote: > > Before, the 'make check-valgrind' merely outputs results to > > tests/testsuite.dir/*/valgrind* and depends on users to verify any errors > > in those files. This patch greps results and shows a summary. > > > > The patch adds '-' before $(SHELL) so that even if test case fails, > > the make continues executing and reports total errors. The additional > > option --errors-for-leak-kinds=definite will force valgrind's definite > > memory leaks as errors and show at the last line of valgrind.* as > > "ERROR SUMMARY: <N> errors". In addition, at the end, add checks for > > valgrind's error patterns. > > > > Signed-off-by: William Tu <u9012...@gmail.com> > > --- > > v1->v2 > > - remove check-valgrind-verbose, merge into check-valgrind > > - use $(EGREP) instead of grep > > - if user has .valgrindrc set to '-q', then no SUMMARY will show up, > > but the error pattern checking at the end will catch the error > if any. > > That's a lot of shell script to put in a Makefile. Can we put it into a > separate script instead? > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
