Acked-by: Ryan Moats <[email protected]> "dev" <[email protected]> wrote on 03/28/2016 04:31:41 PM:
> From: Gurucharan Shetty <[email protected]> > To: [email protected] > Cc: Gurucharan Shetty <[email protected]> > Date: 03/28/2016 04:48 PM > Subject: [ovs-dev] [PATCH] ovn-northd: Fix peering of routers. > Sent by: "dev" <[email protected]> > > 1. Currently, the ovn-nb man page says that the 'peer' > in a logical_router_port table should point to the name > of the peer's logical router port. But the schema had declared > this column as a uuid. This looks not to be the intention as peers > for logical switches connected to routers is a name (and not a uuid). > So this patch changes the schema to be name. > > 2. In the southbound database, in the port_binding table, for a > logical_router_port, the peer was pointing back to itself. This > was causing ovn-controller to create patch ports where the peer > was wrongly pointing back to the source itself. This clearly looks > to be an error. So this patch fixes the peer in southbound database > to correclty point to the real peer. > > 3. ovn-northd.c currently skips generating logical flows to transfer > packets between two peers with comment about needing 'ARP for > neighboring routers'. It looked to me that since the router peer > is a logical object that has to be created in OVN-NB database, we > always need to statically assign the mac address. So this patch > picks the mac address from the database. > > Signed-off-by: Gurucharan Shetty <[email protected]> > --- > ovn/northd/ovn-northd.c | 28 ++++++++- > ovn/ovn-nb.ovsschema | 9 +-- > tests/ovn.at | 155 ++++++++++++++++++++++++++++++++++++ > +++++++++++ > 3 files changed, 184 insertions(+), 8 deletions(-) _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
