Comments inlined. Thanks, Alin.
> -----Mesaj original----- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Friday, March 25, 2016 8:07 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH v2] datapath-windows: Update Recirculation to > use the right parameters > > Update OvsLookupFlow() to include flowKey->RecircId when computing > hash. [Alin Gabriel Serdean: ] https://github.com/openvswitch/ovs/blob/106dc9059176bf6b2b48016cd228e3623661bc94/datapath-windows/ovsext/Flow.c#L1385 https://github.com/openvswitch/ovs/blob/106dc9059176bf6b2b48016cd228e3623661bc94/datapath-windows/ovsext/Flow.c#L2125-L2126 (it is included) > Use the right source port Id for checking if a packet is received or > transmitted. [Alin Gabriel Serdean: ] https://github.com/openvswitch/ovs/blob/106dc9059176bf6b2b48016cd228e3623661bc94/datapath-windows/ovsext/Actions.c#L1932-L1933 (it is the right source port id) > > Signed-off-by: Sairam Venugopal <vsai...@vmware.com> > --- > datapath-windows/ovsext/Actions.c | 2 +- > datapath-windows/ovsext/Flow.c | 3 +++ > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/datapath-windows/ovsext/Actions.c b/datapath- > windows/ovsext/Actions.c > index a91454d..7742096 100644 > --- a/datapath-windows/ovsext/Actions.c > +++ b/datapath-windows/ovsext/Actions.c > @@ -2015,7 +2015,7 @@ OvsDoRecirc(POVS_SWITCH_CONTEXT > switchContext, > } > status = OvsCreateAndAddPackets(NULL, 0, OVS_PACKET_CMD_MISS, > vport, key, ovsFwdCtx.curNbl, > - srcPortNo == > + > + ovsFwdCtx.fwdDetail->SourcePortId == > switchContext->virtualExternalPortId, > &ovsFwdCtx.layers, > ovsFwdCtx.switchContext, diff --git > a/datapath- > windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c index > 02c41b7..d49697c 100644 > --- a/datapath-windows/ovsext/Flow.c > +++ b/datapath-windows/ovsext/Flow.c > @@ -2133,6 +2133,9 @@ OvsLookupFlow(OVS_DATAPATH *datapath, > > if (!hashValid) { > *hash = OvsJhashBytes(start, size, 0); > + if (key->recircId) { > + *hash = OvsJhashWords((UINT32*)hash, 1, key->recircId); > + } > } > > head = &datapath->flowTable[HASH_BUCKET(*hash)]; > -- > 2.5.0.windows.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
