On Wed, Mar 23, 2016 at 5:05 PM, Ben Pfaff <b...@ovn.org> wrote:
> On Mon, Mar 21, 2016 at 03:40:01PM -0500, Ryan Moats wrote:
> > From: RYAN D. MOATS <rmo...@us.ibm.com>
> >
> > OVN NB & SB DB's should be run in separate ovsdb-server processes
> > and should run with ovn-ctl start_northd / stop_northd. This patch
> > includes changes to unit tests, tutorial and debian scripts to remain
> > self-consistent.
> >
> > Signed-off-by: RYAN D. MOATS <rmo...@us.ibm.com>
> > Signed-off-by: Michael Arnaldi <arnaldimichael at gmail.com>
>
> This seems OK to me.
>
> From our IRC conversation, it sounds like there should be a
> Co-authored-by for Michael Arnaldi.
>
> Since Russell has taken the lead on this I'll leave the final review and
> apply to him.
>
Thanks for working on this Michael and Ryan! The latest version looked
good to me. I applied it to master with the following minor changes: a
whitespace fix, adding Michael to AUTHORS, and removing duplicate help text.
diff --git a/AUTHORS b/AUTHORS
index 9e44e4c..f0d1e23 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -141,6 +141,7 @@ Martino Fornasa m...@fornasa.it
Maryam Tahhan maryam.tah...@intel.com
Mauricio Vásquez mauricio.vasquezber...@studenti.polito.it
Mehak Mahajan mmaha...@nicira.com
+Michael Arnaldi arnaldimich...@gmail.com
Michal Weglicki michalx.wegli...@intel.com
Mijo Safradin m...@linux.vnet.ibm.com
Minoru TAKAHASHI takahashi.mino...@gmail.com
diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl
index 9dbaa64..4348d6e 100755
--- a/ovn/utilities/ovn-ctl
+++ b/ovn/utilities/ovn-ctl
@@ -230,7 +230,6 @@ Options:
this is set to "no", the "start_ovsdb"
and
"stop_ovsdb" commands must be used to
start
and stop the OVN databases.
- --ovn-manage-ovsdb=no manage ovsdb separately from
start_northd and stop_northd
--ovn-controller-log=STRING ovn controller process logging params
(default: $OVN_CONTROLLER_LOG)
--ovn-northd-log=STRING ovn northd process logging params
(default: $OVN_NORTHD_LOG)
--ovn-nb-log=STRING ovn NB ovsdb-server processes logging
params (default: $OVN_NB_LOG)
diff --git a/tutorial/ovs-sandbox b/tutorial/ovs-sandbox
index 51e3a9f..f331a00 100755
--- a/tutorial/ovs-sandbox
+++ b/tutorial/ovs-sandbox
@@ -365,7 +365,7 @@ if $ovn; then
--ovnsb-db=unix:"$sandbox"/ovnsb_db.sock \
--ovnnb-db=unix:"$sandbox"/ovnnb_db.sock
rungdb $gdb_ovn_controller $gdb_ovn_controller_ex ovn-controller \
- --detach --no-chdir --pidfile -vconsole:off --log-file
+ --detach --no-chdir --pidfile -vconsole:off --log-file
rungdb $gdb_ovn_controller_vtep $gdb_ovn_controller_vtep_ex \
ovn-controller-vtep --detach --no-chdir --pidfile -vconsole:off \
--log-file --ovnsb-db=unix:"$sandbox"/ovnsb_db.sock
--
Russell Bryant
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
