On Sun, Feb 28, 2016 at 10:33:23PM -0800, Gurucharan Shetty wrote:
> Invalid packets get dropped. Established connectections
> need to be sent through conntrack with just "nat" so
> that the VIP is changed to a loadbalanced IP address (by
> setting reg1 = 2). New connections need to be loadbalanced
> to one of the destination IP addresses (by setting reg1 = 3).
> 
> This introduces 2 OVN lflow actions.
> 1. ct_nat. This is used to send packets to conntrack to NAT
> them for already established connections.
> 2. ct_lb($ips). This is used to choose one of the $ips as
> destination ip address for new connections that need to
> be loadbalanced.
> 
> Signed-off-by: Gurucharan Shetty <g...@ovn.org>

The patch order seems wrong here, shouldn't the new actions be
implemented before ovn-northd tries to use them?

There's a stray ) in this comment:
> +            /* If reg1 is set as 3, then packets should be sent through
> +             * nat and committed). */

We're coming close to the point where we need to be able to define names
for registers and their subranges to make the logical flows more
readable.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to