-----Original Message----

> @@ -256,8 +258,17 @@  physical_run(struct controller_ctx *ctx, enum
mf_field_id mff_ovn_geneve,
>          } else {
>              ofport = u16_to_ofp(simap_get(&localvif_to_ofport,
>                                            binding->logical_port));
> -            if (!strcmp(binding->type, "localnet") && ofport &&
binding->tag) {
> -                tag = *binding->tag;
> +
> +            if ((!strcmp(binding->type, "localnet") ||
> +                (!strcmp(binding->type, "vtep"))) && ofport &&
> +                 binding->phys_endpt) {
> +
> +                phys_endpt_rec = binding->phys_endpt;
> +                /* only single vlan encap is supported initially */
> +                if (phys_endpt_rec && (!strcmp(phys_endpt_rec->type,
"vlan"))) {
> +                    /* valid values verified on configuration */
> +                    (void) str_to_int(phys_endpt_rec->ingress_encap, 10,
&tag);
> +                }

Darrell, if I read this correctly, binding->phys_endpt has to be non-NULL
to enter the conditional block.  Doesn't that render the test on
phys_endpt_rec
being non-NULL unnecessary?

Ryan (regXboi)
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to