On 02/03/2016 06:34, "Ilya Maximets" <i.maxim...@samsung.com> wrote:
>Hi, Daniele.
>
>Comment inline.
>
>Best regards, Ilya Maximets.
>
>On 28.02.2016 23:13, Daniele Di Proietto wrote:
>> This introduces in dpif-netdev and netdev-dpdk the first use for the
>> newly introduce reconfigure netdev call.
>>
>> When a request to change the number of queues comes, netdev-dpdk will
>> remember this and notify the upper layer via
>> netdev_request_reconfigure().
>>
>> The datapath, instead of periodically calling netdev_set_multiq(), can
>> detect this and call reconfigure().
>>
>> This mechanism can also be used to:
>> * Automatically match the number of rxq with the one provided by qemu
>> via the new_device callback.
>> * Provide a way to change the MTU of dpdk devices at runtime.
>>
>> Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com>
[...]
>> @@ -809,11 +816,13 @@ static int
>> netdev_dpdk_set_config(struct netdev *netdev, const struct smap *args)
>> {
>> struct netdev_dpdk *dev = netdev_dpdk_cast(netdev);
>> + int new_n_rxq = MAX(smap_get_int(args, "n_rxq",
>>dev->requested_n_rxq), 1);
>
>This should be done under dev->mutex.
You're right, fixed
I'll change that and send a v2 in a minute.
Thanks for your review!
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
