On 29.02.2016 21:44, Ben Pfaff wrote: > On Mon, Feb 29, 2016 at 04:06:52PM +0300, Ilya Maximets wrote: >> 'make check-system-userspace', 'make check-kernel' and 'make check-kmod' >> work with real environment and can not be run simultaneously. >> >> To prevent violation of the system environment strip out options for >> parallel execution from TESTSUITEFLAGS for this targets. >> >> Signed-off-by: Ilya Maximets <i.maxim...@samsung.com> > > TESTSUITEFLAGS_WITHOUT_JOBS can be more simply defined as just > $(filter-out -j% --jobs=%, $(TESTSUITEFLAGS))
This can't filter out something like '-j 8' because of whitespaces inside the pattern. Anyway, unfortunately, I found that this all is a GNU extensions for make and we can't use them for portability reasons. '$(filter-out', '$(shell' and even 'define' should be replaced with another portable implementation. > Do you think it's really worth warning about this? It's very confusing that I can use usual 'make check' in parallel mode, but can't do the same with other testsuites. In addition, this behaviour isn't documented at all. Best regards, Ilya Maximets. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
