On Mon, Feb 22, 2016 at 07:58:32PM +0000, Lutz, Arnoldo wrote: > > Modified ovsdb_idl_row structure to include information on partial map > updates, > which will be used to create mutate operations on map columns when the > transaction is committed. > > Also filled out generic (skeleton) functions to populate partial map update > information on the row when a map is partially written or partially deleted. > > Clear PMU lists when a row is deleted > > Row's lists of Partial Map Updates are now cleared and deleted when such row > is > deleted. > > Add row to transaction's list on PMU > > When a Partial Map Update is requested, the modified row is added to the > transaction's list of rows, so a mutate operation could be generated on > commit. > > Remove partial_map from ovsdb_idl_txn_writte__() > > Removes parameter 'partial_map' from ovsdb_idl_txn_writte__() function, > because > it is no longer needed there. Partial Map Updates are now handle in separate > code, that doesn't disrupt the inner working of transaction writes nor other > operation generations during commits. > > Clear PMULs when transaction finish > > Clear all Partial Map Update Lists when the transaction is finished. > > Also fixes logic for making operations for one row in commits. > > Signed-off-by: Edward Aymerich <edward.aymer...@hpe.com>
This fixes the new compiler warnings from the previous commit, but it adds a lot of code whose purpose isn't really obvious. At the very least the new public functions in ovsdb-idl.h need some comments explaining their purpose. I don't like how this adds commented-out code. That seems really mysterious. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
