Acked-by: Sairam Venugopal <vsai...@vmware.com>
On 2/26/16, 6:10 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >Found by inspection. > >Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> >--- > lib/netlink-socket.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-) > >diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c >index 5ef4b15..42d475b 100644 >--- a/lib/netlink-socket.c >+++ b/lib/netlink-socket.c >@@ -49,20 +49,6 @@ COVERAGE_DEFINE(netlink_sent); > #define SOL_NETLINK 270 > #endif > >-#ifdef _WIN32 >-static struct ovs_mutex portid_mutex = OVS_MUTEX_INITIALIZER; >-static uint32_t g_last_portid = 0; >- >-/* Port IDs must be unique! */ >-static uint32_t >-portid_next(void) >- OVS_GUARDED_BY(portid_mutex) >-{ >- g_last_portid++; >- return g_last_portid; >-} >-#endif /* _WIN32 */ >- > /* A single (bad) Netlink message can in theory dump out many, many log > * messages, so the burst size is set quite high here to avoid missing >useful > * information. Also, at high logging levels we log *all* Netlink >messages. */ >@@ -567,7 +553,7 @@ nl_sock_recv__(struct nl_sock *sock, struct ofpbuf >*buf, bool wait) > if (!DeviceIoControl(sock->handle, sock->read_ioctl, > NULL, 0, tail, sizeof tail, &bytes, NULL)) { > VLOG_DBG_RL(&rl, "fatal driver failure in transact: %s", >- ovs_lasterror_to_string()); >+ ovs_lasterror_to_string()); > retval = -1; > /* XXX: Map to a more appropriate error. */ > errno = EINVAL; >-- >1.9.5.msysgit.0 >_______________________________________________ >dev mailing list >dev@openvswitch.org >https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma >n_listinfo_dev&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Dc >ruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=9yvN6gGc_QmgQJjCAWsT74D5O6mFtp >u-_9bd8ZCTgAA&s=7goIj1F1y6ZZh7fKD83OiX4ei4Wh9DAJ0WBbJxYHD2o&e= _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev