On Mon, Feb 22, 2016 at 11:35 AM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Feb 02, 2016 at 05:36:47PM -0500, Russell Bryant wrote: > > Run json.at tests for both Python 2 and 3 if available. > > > > Signed-off-by: Russell Bryant <russ...@ovn.org> > > The new comment here is nice: > > +# JSON_CHECK_POSITIVE_PY(TITLE, INPUT, OUTPUT, TEST-JSON-ARGS, > > +# PYTHON-CHCEK, PYTHON-BIN) > > +# > > ...and so it would be nice to have a similar new comment here: >
Good idea, I added it. > > m4_define([JSON_CHECK_NEGATIVE_PY], > > [AT_SETUP([$1]) > > AT_KEYWORDS([json negative Python]) > > - AT_SKIP_IF([test $HAVE_PYTHON = no]) > > + AT_SKIP_IF([test $5 = no]) > > AT_CHECK([printf %s "AS_ESCAPE([$2])" > input]) > > AT_CAPTURE_FILE([input]) > > - AT_CHECK([$PYTHON $srcdir/test-json.py $4 input], [1], [stdout], []) > > + AT_CHECK([$6 $srcdir/test-json.py $4 input], [1], [stdout], []) > > AT_CHECK([[sed 's/^error: [^:]*:/error:/' < stdout]], [0], [$3 > > ]) > > AT_CLEANUP]) > > Acked-by: Ben Pfaff <b...@ovn.org> > -- Russell Bryant _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
