On Tue, Feb 02, 2016 at 05:36:46PM -0500, Russell Bryant wrote: > Update the tests in check-structs.at to run with both Python 2 and 3 if > available. The check-structs script is written in Python, though does > not use the ovs Python library. The script did require fixes in a > previous commit to make it Python 3 compatible, so this ensures that > compatibility remains. > > Signed-off-by: Russell Bryant <russ...@ovn.org>
With all patches applied, on top of commit b1e04512f7150AA9 (from roughly when you posted the patches) I'm getting several errors from flake8 regarding check-structs: ../build-aux/check-structs:70:24: F821 undefined name 'inputFile' ../build-aux/check-structs:71:17: F821 undefined name 'lineNumber' ../build-aux/check-structs:73:40: F821 undefined name 'inputFile' ../build-aux/check-structs:77:40: F821 undefined name 'fileName' ../build-aux/check-structs:77:50: F821 undefined name 'inputFile' ../build-aux/check-structs:94:23: F821 undefined name 'fileName' ../build-aux/check-structs:94:33: F821 undefined name 'lineNumber' ../build-aux/check-structs:101:48: F821 undefined name 'fileName' ../build-aux/check-structs:101:58: F821 undefined name 'lineNumber' ../build-aux/check-structs:111:36: E711 comparison to None should be 'if cond is not None:' I'm using flake8 for Python2, version 2.2.2. Any ideas? I haven't investigated yet, except to note that the final complaint about comparison to None is correct. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
