On 2/15/16, 1:34 PM, "dev on behalf of Russell Bryant"
<dev-boun...@openvswitch.org on behalf of russ...@ovn.org> wrote:
>I imagine Justin is doing the in depth review on this one, but I wanted
>to mention some minor things.
>
>
>On 02/12/2016 08:12 PM, Darrell Ball wrote:
>> Signed-off-by: Darrell Ball <db...@vmware.com>
>
>The patch author email address and Signed-off-by don't match. It seems
>like you have git configured to use gmail, but then manually put in
>vmware when typing in the Signed-off-by header? I'm not sure this is a
>real problem, but it just caught my eye as an unexpected thing ...
>
>> ---
>> AUTHORS | 1 +
>> ovn/controller-vtep/vtep.c | 207
>> ++++++++++++++++++++++++++++++++++++++++-----
>> 2 files changed, 186 insertions(+), 22 deletions(-)
>>
>> diff --git a/AUTHORS b/AUTHORS
>> index 5c3643a..b709482 100644
>> --- a/AUTHORS
>> +++ b/AUTHORS
>> @@ -417,6 +417,7 @@ rahim entezari rahim.entez...@gmail.com
>> 胡靖飞 hujingfei...@msn.com
>> 张伟 zhang...@126.com
>> 张强 zhangqi...@meizu.com
>> +darrell ball dlu...@gmail.com
>
>You should add yourself into the section earlier in the file that lists
>authors of commits. The entry should also be inserted in alphabetical
>order.
Ahh; upon looking at the actual contents :-), I see its a “CONTRIBUTORS” file
with two sections and with loosely enforced alphabetical ordering
Thanks
>
>>
>> Thanks to all Open vSwitch contributors. If you are not listed above
>> but believe that you should be, please write to dev@openvswitch.org.
>> diff --git a/ovn/controller-vtep/vtep.c b/ovn/controller-vtep/vtep.c
>> index 016c2e0..04251c4 100644
>> --- a/ovn/controller-vtep/vtep.c
>> +++ b/ovn/controller-vtep/vtep.c
>> @@ -30,6 +30,16 @@
>>
>> VLOG_DEFINE_THIS_MODULE(vtep);
>>
>> +struct vtep_rec_physical_locator_list_entry{
>
>There should be a space before {. There's some other minor style issues
>throughout the patch. Take a look at CodingStyle.md.
I’ll sift through the file again to try to find the style issues missed earlier
Thanks
>
>--
>Russell Bryant
>_______________________________________________
>dev mailing list
>dev@openvswitch.org
>http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
