On Thu, Feb 04, 2016 at 08:04:53PM -0800, Jesse Gross wrote:
> On Thu, Feb 4, 2016 at 7:55 PM, Pravin B Shelar <pshe...@ovn.org> wrote:
> > There are multiple issues in IPv6 userspace tunnel
> > implementation. There is not enough time to get all
> > fixes in branch-2.5. So it make sense to disable the
> > support on 2.5.
> >
> > Signed-off-by: Pravin B Shelar <pshe...@ovn.org>
> 
> This will also affect the kernel implementation - I think that's what
> we want because it's not documented or supported in the kernel module
> that will ship as part of 2.5. However, the commit message isn't quite
> accurate.
> 

Is the problem time to code or time to test? I have some of the fixes on my
queue, working on tnl-ports, expect to have it ready today. Will try to have
better tests for those broken pieces as well, but not sure I can get those
before next week.

Cascardo.

> > diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
> > index 88f5022..2234de7 100644
> > --- a/lib/netdev-vport.c
> > +++ b/lib/netdev-vport.c
> > @@ -503,6 +503,10 @@ set_tunnel_config(struct netdev *dev_, const struct 
> > smap *args)
> >                            name, node->value);
> >                  return EINVAL;
> >              }
> > +            if (dst_proto == ETH_TYPE_IPV6) {
> > +                VLOG_WARN("%s: IPv6 'remote_ip' is not supported", name);
> > +                return EOPNOTSUPP;
> > +            }
> 
> I believe that this won't catch the case where the address is set to
> "flow". I think we probably also need to block attempts to set or
> match IPv6 addresses through OpenFlow.
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to