On 02/04/2016 05:05 AM, Ben Pfaff wrote: > I'm concerned about this patch for a couple of reasons. First, the goal > of the ovsdb_idl_loop abstraction is to make it easy for clients to get > all of this stuff right. This patch adds more code outside the > ovsdb_idl_loop implementation in its client, somewhat reducing the value > of the abstraction. It would be better if we could instead integrate > the logic into ovsdb_idl_loop itself.
Thanks for the review and comments Ben. I agree. > My second concern is larger. TXN_ERROR is supposed to indicate a hard > error, one for which retrying immediately is not going to help. What > kind of error did testing actually encounter? Perhaps the real bug is > that an error is being misclassified as TXN_ERROR. I will investigate it further to see why TXN_ERROR is returned. Thanks Numan _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
