On Thu, Jan 28, 2016 at 3:51 PM, Aaron Conole <acon...@redhat.com> wrote:
> Christian Ehrhardt <christian.ehrha...@canonical.com> writes: > > Hi Aaron > > > > I refreshed my stack that combines your current series with the > vhost-user > > permission/ownership work of december. > > > > quilt applied > > > patches/ovs-dev-v7-1-5-netdev-dpdk-Restore-thread-affinity-after-DPDK-init.patch > > > patches/ovs-dev-v7-2-5-netdev-dpdk-Convert-initialization-from-cmdline-to-db.patch > > > patches/ovs-dev-v7-3-5-netdev-dpdk-Autofill-lcore-coremask-if-absent.patch > > patches/ovs-dev-v7-4-5-netdev-dpdk-Allow-arbitrary-eal-arguments.patch > > > patches/ovs-dev-v7-5-5-NEWS-Announce-the-DPDK-EAL-configuration-change.patch > > > patches/ovs-dev-4-5-lib-daemon-Move-the-user-group-code-up-one-level.patch > > patches/ovs-dev-5-5-netdev-dpdk-Support-user-cfg-vhost-socket-perms.patch > > > > It passes all the tests I had yesterday > > That's great to know! :) > > > dpdk|INFO|User-provided vhost-sock-dir in use: > /usr/local/var/run/openvswitch-vhost > > dpdk|INFO|User-provided vhost_sock_owners in use: :kvm > > dpdk|INFO|User-provided vhost_sock_permissions in use: 0660 > > dpdk|INFO|Socket /usr/local/var/run/openvswitch-vhost/vhost-user-1 > created for vhost-user > > port vhost-user-1 > > dpdk|INFO|Socket /usr/local/var/run/openvswitch-vhost/vhost-user-1 > changed permissions to > > 0660 > > dpdk|INFO|Socket /usr/local/var/run/openvswitch-vhost/vhost-user-1 > changed ownership to > > :kvm > > > > So the issue with dpdk-alloc-mem is fixed - thanks. > > I guess I only use hugepages, so I never properly tested this. I've > added a few scripts, and will start work on a separate series of tests > to add to the testdir to do these kinds of tests. Great that I could help identify a weak spot in testing, and even better you already plan for tests on that - thanks! BTW - this uses huge pages as well, just not node bound. Since some of my tests are in virtual systems without (virtual) numa nodes I was using just -m (=alloc-mem) to keep the same config for now. > > The remaining issue with the range check for the permissions doesn't > belong to this series > > :-) > > While I agree to the communities assessment in December that they should > be discussed > > split, so the second series doesn't stall the former one. > > I'd consider it great to submit them always together, but as two series. > So one 0/5 and one > > 0/2. > > It's a bit of a chicken-egg problem, and there's really no good way of > doing it. I'd like to just prevent folks from trying to apply the second > series without the first (plus many times it's considered inappropriate > to submit a patch series which depends on an unaccepted series). I agree > though, it's confusing. > > > That way we keep the people aware and avoid people doing the same work > over and over > > again (me and just today e.g. by Robert Wojciechowicz) > > It would simplify testing both, but still keep discussions as separate > as needed. > > It's not a problem for me. I have updated the second series to include > your note on the default permissions and the parsing, so I can post them > as RFC or with some other tag, if you want. > I can work with my ported old December serier, but yes I think it would help to just drop the updated series as RFC so people are more aware of that good work. I agree that we have to wait to get the first series accepted to really consider the second. > > I might seem to miss something obvious (feels that way), but fyi with > the series various > > parts of "make check" fail. > > After realizing this I more or less blindly ran a loop of "quilt push; > make -j12 && make check > > TESTSUITEFLAGS=-j12" to see which of the patches triggers this behavior. > > It is #2 > "ovs-dev-v7-2-5-netdev-dpdk-Convert-initialization-from-cmdline-to-db.patch" > > A lot of tests report fail, and it keeps "hanging" since some seem no > more to end correctly. > > Here a log of my "make check TESTSUITEFLAGS=-j12" > > http://paste.ubuntu.com/14688004/ > > D'oh! I've got some fixes. Looks like my jenkins setup has been running > make > check without dpdk and I never noticed :/ I've fixed it, and will have a > v8 posted today. > > > I didn't look into it in detail yet - is that a real issue, or am I > missing just some sort of DB > > upgrade or so? > > Some are actual issues (possibly with ovsthread_once_start? - I'm > investigating), and some are stupid non-issues (I added a log to the > vswitchd without properly accounting for the check in OVS_VSWITCHD_START) > > If you want to get past the errors, you can edit tests/ofproto-macros.at > and change the _OVS_VSWITCHD_START macro to include > /dpdk|INFO|DPDK Disabled - to change this requires a restart./d > in the sed line. > I don't mind the errors for now and I'm glad I could help to find the little misconfig in your Jenkins setup. > Thanks so much for the feedback and testing, Christian! I'm on travel next week, but will try to test v8 with the expected fixes as good as I can. Back in two weeks I plan to make my setup more useful and give it a better test then. But there are a few configuration issues which still delay me (guests can't reach anything yet) - not related to what we discuss here :-) _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
