On 22 January 2016 at 07:12, Lance Richardson <lrich...@redhat.com> wrote: > Test cases using netcat ("ICMP related" and "ICMP related with NAT") > currently fail on systems using the nmap version of nc because this > version does not support the -q command-line option. > > Fix this by detecting which version of netcat is is in use and > using the "--send-only" command-line option when the nmap flavor > is detected, and using "-q 1" otherwise (openbsd and traditional > versions). > > Tested via "make check-kernel" on RHEL7 (nmap version of nc) and > Debian 8.2 (openbsd version of nc). > > --- > v2: > - Restore the use of netcat in "ICMP related" test case, > using appropriate nc options based on installed version. > - Removed comments in system-traffic.at regarding the use of the > -q option. > > Signed-off-by: Lance Richardson <lrich...@redhat.com>
Thanks for the contribution, I tested this using netcat-traditional and pushed the series to master. For future reference, please place the "Signed-off-by" line above the "---", as anything below the "---" is dropped from the commit message by git-am. However we want to retain any signoffs into the commit message. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev