On Thu, Jan 21, 2016 at 11:05 PM, pravin shelar <pshe...@ovn.org> wrote:
> On Thu, Jan 21, 2016 at 3:41 PM, Jesse Gross <je...@kernel.org> wrote:
>> On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar <pshe...@nicira.com> wrote:
>>> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
>>> index c746cc2..215e9b6 100644
>>> --- a/lib/dpif-netdev.c
>>> +++ b/lib/dpif-netdev.c
>>> @@ -3529,8 +3528,12 @@ dp_execute_cb(void *aux_, struct dp_packet
>>> **packets, int cnt,
>>> packets = tnl_pkt;
>>> }
>>>
>>> - err = netdev_pop_header(p->netdev, packets, cnt);
>>> + err = netdev_pop_header(p->netdev, packets, &cnt);
>>> + if (!cnt) {
>>> + return;
>>> + }
>>
>> Is this safe in the event that may_steal is false? It seems like the
>> caller could free a packet that we are trying to hold.
>>
> if may_steal is false then we make a copy of the batch of packet, ref
> dp_netdev_clone_pkt_batch().
Ah, right.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
