-----Original Message----- From: dev <[email protected]> on behalf of Alin Serdean <[email protected]> Date: Tuesday, January 12, 2016 at 11:30 PM To: "[email protected]" <[email protected]> Subject: [ovs-dev] [PATCH] datapath-windows: fix endless loop on reboot
>Testing under 2012 gave some more inisight on an old bug. > >If a PNP event with the value of NetEventSwitchActivate was triggered >we were calling OvsQuerySwitchActivationComplete which does an OID request >to the underlying drivers, however this triggered a hang because as per >documentation: >https://urldefense.proofpoint.com/v2/url?u=https-3A__msdn.microsoft.com_en >-2Dus_library_windows_hardware_ff561830-2528v-3Dvs.85-2529.aspx&d=BQIGaQ&c >=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnB >sxdDuTLBYD3JqV80&m=Fj7uJymmPSbRugLjBBXZ1nPgsYleIwSrrg8fejzqTNI&s=gKMD9jVG0 >vYng0UM7tcfgbnXE7FIsHrxgugOXwlMbug&e= >"A driver can call NdisFOidRequest when it is in the Restarting, Running, >Pausing, or Paused state." >This resulted in an endless booting cycle. >Looking at the documentation again: >https://urldefense.proofpoint.com/v2/url?u=https-3A__msdn.microsoft.com_en >-2Dus_library_windows_hardware_ff568751-2528v-3Dvs.85-2529.aspx&d=BQIGaQ&c >=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnB >sxdDuTLBYD3JqV80&m=Fj7uJymmPSbRugLjBBXZ1nPgsYleIwSrrg8fejzqTNI&s=YXIlD9Tq5 >BECpZVVTumaSxAfl-Gg8C845QAeeh9iGBI&e= >NetEventSwitchActivate indicates that the extensible switch has completed >activation so we can now safely query the switch itself. > >Also we are not forwarding the PNP event to the overlaying drivers unless >we succeeded in the operation, this issue has been fixed also. > >Signed-off-by: Alin Gabriel Serdean <[email protected]> > Thanks for the fix. Acked-by: Nithin Raju <[email protected]> _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
