On Tue, Jan 19, 2016 at 12:50:34PM -0800, Jarno Rajahalme wrote:
> With a question (or two) for clarification below:
>
> Acked-by: Jarno Rajahalme <ja...@ovn.org>
Thanks, I applied this to master.
...
> > static int
> > +netdev_dummy_get_queue(const struct netdev *netdev OVS_UNUSED,
> > + unsigned int queue_id, struct smap *details)
> > +{
> > + if (queue_id == 0) {
> > + smap_add(details, "key", "value”);
>
> What is the function of adding this key/value-pair to the smap?
At first I was going to actually add some useful key-value pairs, but
then I realized there weren't any. I think I forgot to go back and
revise.
I've removed this now.
> > +static int
> > +netdev_dummy_queue_dump_next(const struct netdev *netdev OVS_UNUSED,
> > + void *state_,
> > + unsigned int *queue_id, struct smap *details)
> > +{
> > + struct netdev_dummy_queue_state *state = state_;
> > + if (state->next_queue == 0) {
> > + *queue_id = 0;
> > + smap_add(details, "key", "value”);
>
> Could this use ‘netdev_dummy_get_queue’ instead?
Yes, but with netdev_dummy_get_queue() now not adding this, it would be
a no-op. I removed the smap_add() call here too, and if we make the
dummy more realistic we can add the netdev_dummy_get_queue() call.
Thanks,
Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
