On Tue, Jan 12, 2016 at 1:55 PM, Janusz Wolak <janusz...@awokados.com.pl> wrote: > Removed: block comments trailing without separate line, > missing blanks after decarations, comparasion to NULL, assignment in if > condition, not necessary spaces after a casts, multiple assignments, line > over 80 characters, alignment not matched to open parenthesis, kmalloc with > multiplying instead kmalloc_array. > > > Signed-off-by: Janusz Wolak <janusz...@awokados.com.pl> > --- > net/openvswitch/datapath.c | 75 > ++++++++++++++++++++++++++-------------------- > 1 file changed, 42 insertions(+), 33 deletions(-) > > diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c > index 91a8b00..12ff8c2 100644 > --- a/net/openvswitch/datapath.c > +++ b/net/openvswitch/datapath.c
... > @@ -455,8 +457,8 @@ static int queue_userspace_packet(struct datapath *dp, > struct sk_buff *skb, > } > > /* Complete checksum if needed */ > - if (skb->ip_summed == CHECKSUM_PARTIAL && > - (err = skb_checksum_help(skb))) > + err = skb_checksum_help(skb); > + if (skb->ip_summed == CHECKSUM_PARTIAL && err) > goto out; > skb checksum help can be expensive in some cases, so it should be moved inside the if condition block. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
