On 12 January 2016 at 05:12, Flavio Leitner <f...@sysclose.org> wrote:
> On Tue, 12 Jan 2016 09:23:12 +0300
> Ilya Maximets <i.maxim...@samsung.com> wrote:
>
>> On 12.01.2016 07:13, Ben Pfaff wrote:
>> > On Mon, Jan 11, 2016 at 06:24:10PM -0800, Joe Stringer wrote:
>> >> DPDK build was broken after commit 2f8932e8403a ("poll: Suppress
>> >> logging for pmd threads.") due to the following error:
>> >>
>> >> lib/netdev-dpdk.c:245:13: error: static declaration of
>> >> ‘thread_is_pmd’ follows non-static declaration
>> >> lib/ovs-thread.h:526:6: note: previous declaration of
>> >> ‘thread_is_pmd’ was here
>> >>
>> >> Reported-at: https://travis-ci.org/openvswitch/ovs/jobs/101648756
>> >> Fixes: 2f8932e8403a ("poll: Suppress logging for pmd threads.")
>> >> CC: Ilya Maximets <i.maxim...@samsung.com>
>> >> Signed-off-by: Joe Stringer <j...@ovn.org>
>> >
>> > Sorry about that. As long as you've tested it:
>> >
>> > Acked-by: Ben Pfaff <b...@ovn.org>
>>
>> Thanks for patch.
>> Only one comment: I am afraid that the replacement of function can
>> slow down the dpdk_do_tx_copy. What do you think?
>
> Can we rename thread_is_pmd to dpdk_thread_is_pmd() or something
> like that instead?
Thanks for the feedback, I'll send out a v2 soon.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
