Thanks. I applied this to master and branch-2.5. On Wed, Dec 23, 2015 at 09:56:23PM +0000, Yin Lin wrote: > Added signed-off-by to the email body as well as patch itself. > > Rationale: Some lately added targets such as ovsext_make, manpage-check and > thread-safety-check are not files but was not marked as .PHONY. This causes > them to be unnecessarily rebuilt during "make check" and "make install" > process. > > Signed-off-by: Yin Lin <li...@vmware.com> > > > -----Original Message----- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, December 23, 2015 1:51 PM > To: Yin Lin <li...@vmware.com> > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 1/1] Makefile: Mark non-file targets as .PHONY > > Thanks, can you provide a Signed-off-by? The syntax and meaning are > explained in CONTRIBUTING.md: > > Signed-off-by: Author Name <author.name@email.address...> > > Informally, this indicates that Author Name is the author or > submitter of a patch and has the authority to submit it under > the terms of the license. The formal meaning is to agree to > the Developer's Certificate of Origin (see below). > > If the author and submitter are different, each must sign off. > If the patch has more than one author, all must sign off. > > Signed-off-by: Author Name <author.name@email.address...> > Signed-off-by: Submitter Name <submitter.name@email.address...> > > Developer's Certificate of Origin > --------------------------------- > > To help track the author of a patch as well as the submission chain, and be > clear that the developer has authority to submit a patch for inclusion in > openvswitch please sign off your work. The sign off certifies the following: > > Developer's Certificate of Origin 1.1 > > By making a contribution to this project, I certify that: > > (a) The contribution was created in whole or in part by me and I > have the right to submit it under the open source license > indicated in the file; or > > (b) The contribution is based upon previous work that, to the best > of my knowledge, is covered under an appropriate open source > license and I have the right under that license to submit that > work with modifications, whether created in whole or in part > by me, under the same open source license (unless I am > permitted to submit under a different license), as indicated > in the file; or > > (c) The contribution was provided directly to me by some other > person who certified (a), (b) or (c) and I have not modified > it. > > (d) I understand and agree that this project and the contribution > are public and that a record of the contribution (including all > personal information I submit with it, including my sign-off) is > maintained indefinitely and may be redistributed consistent with > this project or the open source license(s) involved. > > > On Wed, Dec 23, 2015 at 09:41:23PM +0000, Yin Lin wrote: > > You are right. Enclosed a new patch. > > > > -----Original Message----- > > From: Ben Pfaff [mailto:b...@ovn.org] > > Sent: Wednesday, December 23, 2015 1:30 PM > > To: Yin Lin <li...@vmware.com> > > Cc: dev@openvswitch.org > > Subject: Re: [ovs-dev] [PATCH 1/1] Makefile: Mark non-file targets as > > .PHONY > > > > manpage-check shouldn't be phony because it actually does create a file > > named manpage-check. > > > > On Wed, Dec 23, 2015 at 09:26:31PM +0000, Yin Lin wrote: > > > Thanks Ben for the prompt reply! I enclosed the patch in the > > > original email. Attaching it again. > > > > > > -----Original Message----- > > > From: Ben Pfaff [mailto:b...@ovn.org] > > > Sent: Wednesday, December 23, 2015 1:25 PM > > > To: Yin Lin <li...@vmware.com> > > > Cc: dev@openvswitch.org > > > Subject: Re: [ovs-dev] [PATCH 1/1] Makefile: Mark non-file targets > > > as .PHONY > > > > > > On Wed, Dec 23, 2015 at 09:23:51PM +0000, Yin Lin wrote: > > > > Some lately added targets such as ovsext_make, manpage-check and > > > > thread-safety-check are not files but was not marked as .PHONY. > > > > This causes them to be unnecessarily rebuilt during "make check" > > > > and "make install" process. > > > > > > Do you have a patch? > > > >
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
