On 12/22/2015 01:31 PM, Ben Pfaff wrote: > On Tue, Nov 24, 2015 at 04:48:59PM +0530, bscha...@redhat.com wrote: >> This patch series introduces native dhcp support in ovn controller. >> v4 has few bug fixes in the test cases >> >> Babu Shanmugam (3): >> ovn: Dedicated connection handler for packet-ins >> ovn: New flows for DHCP tranffic >> ovn: Process dhcp packet-ins and respond through packet-outs >> >> Numan Siddique (1): >> ovn: Add tests for ovn dhcp > Hi Babu and Numan. > > So far, we've been able to build OVN so that the logic of the system is > implemented in terms of OVN logical flows. That is, the logical flow > table determines what happens in every significant way in OVN. It would > be nice to preserve this property for DHCP. A design of this form would > have to include a way for the flow table to extract DHCP header and > option information from packets, and for the flow table to create new > DHCP packets and set their header and option values. It would be more > work, but then the DHCP behavior could be controlled entirely from > ovn-northd by modifying the flow table. > > I'd like to discuss whether this is practical and worth the effort. > > Do you have any initial thoughts?
Thanks Ben for your comments. We agree with you. It would be better that logical flows tell what the reply should be for dhcp. What we understood from your comments is - that the dhcp packets will still be handled as packet-in/packet-out - the logical flows could like some thing like this "match=(inport="some port" and udp src port = 68 and dst port-67), action=(dhcp( offer_ip, gw_ip, netmask, (and other options)) The "dhcp" action would add the packet-in flow and also store the dhcp options something similar to your patch " 14/14] ovn: Implement basic ARP support for L3 logical routers. <https://patchwork.ozlabs.org/patch/554179/>" When the dhcp packet is received as packet-in, the controller would just frame the dhcp reply by getting the dhcp options specified in the logical flows. If our understanding is wrong, could you please provide with sample of logical flow to handle dhcp packets if you have something in mind. Thanks Numan and Babu > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev