On 12/20/2015 08:12 AM, Ofer Ben-Yacov wrote: > Hi Russel, > > to answer your questions: > 1. limitation: the use case for passive mode is that I'm integrating IDL > to L2GW project and passive mode is prerequisite. The change that will > enable usage of the same IP and PORT (full blown server) will require > much more code changes, probably to Neutron also ( Connection object). I > thought it would be better to to it in 2 phases as this phase is good > enough to start with and without it I will not be able to add the IDL to > the L2GW. The only limitation is that if you have more than one OVSDB > server, you will need to use different port for each server. > > 2. Testing: I run system tests to test the code before I sent the patch. > I will take a look at the tests and will try to add some unit tests to > make sure that future development will not break it.
Take a look at tests/ovsdb-idl.at. There's some TCP and TCP6 test cases in there. Maybe you could add a PTCP variant. > 3. One email address per line: gotcha. > > 4. PEP8 check with flake8: I fixed the minor changes you've sent and > also fixed other issues flake8 has found on the files I modified > (including one small bug: idl.py line 1224). I mainly just meant fixing any issues introduced by your patch. If you fix too much else in the same patch, it'll make it harder to review the real code changes. I have most of the general flake8 failures fixed in this patch series, as well: http://openvswitch.org/pipermail/dev/2015-December/063570.html > 5. IPv6: currently, there is no support for IPv6 in the existing code. > The new code I added does not add other complexity to prevent or delay > such support. It looks like IPv6 is tested in tests/ovsdb-idl.at. Take a look and see what you think. > I will submit the new code with the modifications again. Thanks! The convention is to submit the next one with a subject of "[PATCH v2] ...". You can do that with git send-email by adding the --annotate flag to give you a chance to edit the message first. -- Russell Bryant _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
