On 25 November 2015 at 09:36, Pravin Shelar <[email protected]> wrote: > On Sun, Nov 8, 2015 at 1:29 AM, Joe Stringer <[email protected]> wrote: >> Backport IPv4 reassembly from the upstream commit caaecdd3d3f8 ("inet: >> frags: remove INET_FRAG_EVICTED and use list_evictor for the test"). >> >> This is necessary because kernels prior to upstream commit d6b915e29f4a >> ("ip_fragment: don't forward defragmented DF packet") would not always >> track the maximum received unit size during ip_defrag(). Without the >> MRU, refragmentation cannot occur so reassembled packets are dropped. >> >> Signed-off-by: Joe Stringer <[email protected]> >> --- >> acinclude.m4 | 6 + >> datapath/compat.h | 15 + >> datapath/datapath.c | 9 +- >> datapath/linux/Modules.mk | 4 + >> datapath/linux/compat/include/net/inet_frag.h | 57 ++ >> datapath/linux/compat/include/net/inetpeer.h | 16 + >> datapath/linux/compat/include/net/ip.h | 21 + >> datapath/linux/compat/include/net/vrf.h | 26 + >> datapath/linux/compat/inet_fragment.c | 557 +++++++++++++++++++ >> datapath/linux/compat/ip_fragment.c | 737 >> ++++++++++++++++++++++++++ >> 10 files changed, 1447 insertions(+), 1 deletion(-) >> create mode 100644 datapath/linux/compat/include/net/inetpeer.h >> create mode 100644 datapath/linux/compat/include/net/vrf.h >> create mode 100644 datapath/linux/compat/inet_fragment.c >> create mode 100644 datapath/linux/compat/ip_fragment.c >> > > I would prefer to have ip-frag and ipv6-frag as separate modules if it > does not complicate code alot. Have you considered it?
I attempted this early on, but I remember running into some dependency issues with it. I figured that less modules would be simpler, so long as it didn't cause a major divergence in the datapath/*.c code compared to upstream. Would this mean that depending on the kernel version you compile against, you either need to load the compat ovs-frag4/ovs-frag6 modules or not? _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
