On Thu, Nov 19, 2015 at 12:58:41PM -0800, Andy Zhou wrote:
> Rafactor common directory existence check and ownership check into
> a common function. Move daemon's default directory to $RUNDIR, since
> the process may not able to write core file to "/" anymore after the
> user change.
> 
> Signed-off-by: Andy Zhou <az...@ovn.org>

Do you have any idea about the portability of "stat -c"?  I also have
the same concerns here about "chown -R" as I did in a previous patch.

Did you consider changing permissions in a post-install script, instead
of in a per-startup script?

Should the following check for $OVS_GROUP != root also?
> +    # add --user for non root user
> +    if test "$OVS_USER" != "root"; then
> +        set "$@" --user="$OVS_USER":"$OVS_GROUP"
> +    fi
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to