On Fri, Oct 23, 2015 at 02:39:56PM +0530, Babu Shanmugam wrote: > The DHCP packets can be of two types > (1) DHCP Discover > (2) DHCP Request > > For (1), the controller should respond with DHCP offer and for (2), > either DHCP Ack or DHCP Nack should be sent. In this patch, DHCP Nack > is never sent. In case of failures in validating the packet, the > controller does not respond at all. > > For a DHCP packet, the IP address is read from the port binding table > with the source MAC as the search reference. The DHCP options for netmask > and router are expected with key values dhcp_opt_netmask and > dhcp_opt_router respectively. In case of the absence of these options from > logical port entry, default values of 255.255.255.0 and 0.0.0.0 is used > respectively. > > Signed-off-by: Babu Shanmugam <[email protected]> > Signed-off-by: Numan Siddique <[email protected]> > Co-Authored-by: Numan Siddique <[email protected]>
At a glance this seems OK. I'll do a more detailed review when the earlier patches are ready to go. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
