On Wed, Oct 21, 2015 at 09:45:30PM -0700, Andy Zhou wrote:
> Add support for monitor2. When idl starts to run, monitor2 will be
> attempted first. In case the server is an older version that does
> not recognize monitor2. IDL will then fall back to use "monitor"
> method.
>
> Signed-off-by: Andy Zhou <[email protected]>
This is pretty clean, thanks!
In the error case here, it could be worthwhile to check that the
msg->id matches idl->request_id:
} else if (msg->type == JSONRPC_ERROR
&& idl->state == IDL_S_MONITOR2_REQUESTED) {
At a glance, it looks like there's a lot of code duplication between the
new and the old update implementation. Can any of it be cleanly
factored out?
This adds an extra blank line above ovsdb_idl_update_has_lock().
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
