On Tue, Oct 27, 2015 at 10:42:41AM +0530, Saloni Jain wrote:
> >In ovs-ofctl.c, I don't think the table-mod code handles the case where
> >OF1.4 or OF1.5 is enabled but the switch does not support it.
>
> This means that in ovs-ofctl.c, for table-mod, it can happen that OF1.4 and
> OF1.5 are supported, but the switch in table-features capabilities does not
> support eviction or vacancy table-config parameters.
> So after checking the usable version as OF1.4 and OF1.5 for table-mod in
> ovs-ofctl.c, table feature request should be sent to the switch from
> ofctl_mod_table() in order to get the supported capabilities for the given
> table-id and if eviction/vacancy events are supported by switch, then only
> table-mod config property should be set.
I mean that the code should adapt its behavior based on the protocol
version that is actually in use in the OpenFlow connection, rather than
on the protocol versions that are enabled.
> >The syntax seems kind of odd actually. How about "vacancy(low,high)"?
>
> Parentheses - "()" and "{}" are used for command grouping in shell and will
> give error "syntax error:bash: syntax error near unexpected token `('", when
> used with any command.
> So in order to avoid the error, we have to use escape characters or
> single/double quotes around "vacancy(low,high)" in ovs-ofctl mod-table
> command, such that, the command looks like:
> ovs-ofctl -O Openflow14 mod-table br0 0
> 'vacancy(low,high)'
>
> I have also tried for "vacancy[low,high]", that is using square brackets [],
> but I am facing problem in test cases. In file ofproto.at square brackets are
> ignored in AT_CHECK[] and so test case for mod-table for vacancy is failing.
> Other possible syntax are -- vacancy:low-high or vacancy:low,high
vacancy:low,high seems like a reasonable choice to me, too.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
