On Thu, Oct 22, 2015 at 5:56 PM, Justin Pettit <jpet...@nicira.com> wrote: > >> On Oct 22, 2015, at 11:08 AM, Andy Zhou <az...@nicira.com> wrote: >> >> @@ -321,11 +321,8 @@ bfd_get_status(const struct bfd *bfd, struct smap *smap) >> smap_add(smap, "state", bfd_state_str(bfd->state)); >> smap_add(smap, "diagnostic", bfd_diag_str(bfd->diag)); >> smap_add_format(smap, "flap_count", "%"PRIu64, bfd->flap_count); >> ... >> + smap_add(smap, "remote_state", bfd_state_str(bfd->rmt_state)); >> + smap_add(smap, "remote_diagnostic", bfd_diag_str(bfd->rmt_diag)); >> ovs_mutex_unlock(&mutex); > > The man page describing "diagnostic" and "remote_diagnostic" make it sound > like they're only populated on error. It may be worth taking the language > from the RFC. So, "diagnostic" would look along the lines of: > > "A diagnostic code specifying the local system's reason for the last change > in local BFD session state. The error messages are defined in section 4.1 of > [RFC 5880]." > > And "remote_diagnostic" would look along the lines of: > > "A diagnostic code specifying the local system's reason for the last change > in remote BFD session state. The error messages are defined in section 4.1 of > [RFC 5880]."
Make sense. I will send out a separate patch to update the man page. Thanks. > > Acked-by: Justin Pettit <jpet...@nicira.com> > > --Justin > > Thanks for the review. Pushed to master. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
