> On Oct 17, 2015, at 2:07 PM, Ben Pfaff <b...@nicira.com> wrote:
>
>
> + if (!port && sf->field->id == MFF_REG6) {
Is there a reason you're using MFF_REG6 instead of MFF_IN_PORT?
> + sf = ofpact_put_SET_FIELD(ofpacts);
> + sf->field = mf_from_id(MFF_IN_PORT);
> + bitwise_put(UINT64_MAX, &sf->mask, sf->field->n_bytes, 0,
> + sf->field->n_bits);
Is there a reason to use this instead of bitwise_one(), which seems to have
clearer intent? The code right above doesn't do it either, so I'm just curious
if it's not equivalent.
Acked-by: Justin Pettit <jpet...@nicira.com>
--Justin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
