On Thu, Oct 15, 2015 at 01:54:58AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit <jpet...@nicira.com>
It looks like physical_run() will now iterate through every row in the Port_Binding table for each VXLAN tunnel. That seems expensive. Here's a suggested documentation update. diff --git a/ovn/ovn-architecture.7.xml b/ovn/ovn-architecture.7.xml index 47dfc2a..7898f21 100644 --- a/ovn/ovn-architecture.7.xml +++ b/ovn/ovn-architecture.7.xml @@ -634,24 +634,39 @@ <dt>logical input port field</dt> <dd> - A field that denotes the logical port from which the packet - entered the logical datapath. - <!-- Keep the following in sync with MFF_LOG_INPORT in - ovn/controller/lflow.h. --> - OVN stores this in Nicira extension register number 6. (This field is - passed across tunnels as part of the tunnel key.) + <p> + A field that denotes the logical port from which the packet + entered the logical datapath. + <!-- Keep the following in sync with MFF_LOG_INPORT in + ovn/controller/lflow.h. --> + OVN stores this in Nicira extension register number 6. + </p> + + <p> + Geneve and STT tunnel pass this field as part of the tunnel key. + Although VXLAN tunnels do not explicitly carry a logical input port, + OVN only uses VXLAN to communicate with gateways that from OVN's + perspective consist of only a single logical port, so that OVN can set + the logical input port field to this one on ingress to the OVN logical + pipeline. + </p> </dd> <dt>logical output port field</dt> <dd> - A field that denotes the logical port from which the packet will - leave the logical datapath. This is initialized to 0 at the - beginning of the logical ingress pipeline. - <!-- Keep the following in sync with MFF_LOG_OUTPORT in - ovn/controller/lflow.h. --> - OVN stores this in - Nicira extension register number 7. (This field is passed across - tunnels as part of the tunnel key.) + <p> + A field that denotes the logical port from which the packet will + leave the logical datapath. This is initialized to 0 at the + beginning of the logical ingress pipeline. + <!-- Keep the following in sync with MFF_LOG_OUTPORT in + ovn/controller/lflow.h. --> + OVN stores this in Nicira extension register number 7. + </p> + + <p> + Geneve and STT tunnels pass this field as part of the tunnel key. + VXLAN tunnels do not transmit the logical output port field. + </p> </dd> <dt>VLAN ID</dt> Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev