On Fri, Sep 18, 2015 at 1:38 PM, Jesse Gross <je...@nicira.com> wrote:
> On Fri, Sep 18, 2015 at 1:34 PM, Pravin B Shelar <pshe...@nicira.com> wrote:
>> From: Chris J Arges <chris.j.ar...@canonical.com>
>>
>> Upstream commit:
>> openvswitch: allocate nr_node_ids flow_stats instead of
>> num_possible_nodes
>>
>> Some architectures like POWER can have a NUMA node_possible_map that
>> contains sparse entries. This causes memory corruption with openvswitch
>> since it allocates flow_cache with a multiple of num_possible_nodes() and
>> assumes the node variable returned by for_each_node will index into
>> flow->stats[node].
>>
>> Use nr_node_ids to allocate a maximal sparse array instead of
>> num_possible_nodes().
>>
>> The crash was noticed after 3af229f2 was applied as it changed the
>> node_possible_map to match node_online_map on boot.
>> Fixes: 3af229f2071f5b5cb31664be6109561fbe19c861
>>
>> Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com>
>> Acked-by: Pravin B Shelar <pshe...@nicira.com>
>> Acked-by: Nishanth Aravamudan <n...@linux.vnet.ibm.com>
>> Signed-off-by: David S. Miller <da...@davemloft.net>
>>
>> Upstream: bac541e4631(""openvswitch: allocate nr_node_ids flow_stats
>> instead of num_possible_nodes")
>>
>> Signed-off-by: Pravin B Shelar <pshe...@nicira.com>
>
> Acked-by: Jesse Gross <je...@nicira.com>
>
> This one could probably go back to 2.3 and 2.4 as well independent of
> the other upstream changes.
Thanks for review.
I pushed the patch to master, branch-2.3 and branch-2.4.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
