On Thu, Sep 17, 2015 at 04:04:28PM -0700, Joe Stringer wrote:
> From: Andy Zhou <az...@nicira.com>
> 
> User space now may receive re-assembled IP fragments. The user space
> netlink handler can now accept packets with the new OVS_PACKET_ATTR_MRU
> attribute. This allows the kernel to assemble fragmented packets for the
> duration of OpenFlow processing, then re-fragment at output time. Most
> notably this occurs for packets that are sent through the connection
> tracker.
> 
> Note that the MRU attribute is not exported at the OpenFlow layer. As
> such, if packets are reassembled by conntrack and subsequently sent to
> the controller, then OVS has no way to re-serialize the packets to their
> original size.
> 
> Signed-off-by: Andy Zhou <az...@nicira.com>
> Acked-by: Jarno Rajahalme <jrajaha...@nicira.com>

The policy in parse_odp_packet() specifies MRU as a be16 but I think
it's a u16:
+        [OVS_PACKET_ATTR_MRU] = { .type = NL_A_BE16, .optional = true }

Not being able to export MRU to OpenFlow may bite us in OVN, but I guess
we can defer that until it becomes a problem.
  
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to