On Thu, Sep 17, 2015 at 2:42 PM, Pravin Shelar <pshe...@nicira.com> wrote:
> On Tue, Sep 15, 2015 at 9:58 PM, Jesse Gross <je...@nicira.com> wrote:
>> Upstream commit:
>> openvswitch: Fix mask generation for nested attributes.
>>
>> Masks were added to OVS flows in a way that was backwards compatible
>> with userspace programs that did not generate masks. As a result, it is
>> possible that we may receive flows that do not have a mask and we need
>> to synthesize one.
>>
>> Generating a mask requires iterating over attributes and descending into
>> nested attributes. For each level we need to know the size to generate
>> the
>> correct mask. We do this with a linked table of attribute types.
>>
>> Although the logic to handle these nested attributes was there in
>> concept,
>> there are a number of bugs in practice. Examples include incomplete links
>> between tables, variable length attributes being treated as nested and
>> missing sanity checks.
>>
>> Signed-off-by: Jesse Gross <je...@nicira.com>
>> Acked-by: Pravin B Shelar <pshe...@nicira.com>
>> Signed-off-by: David S. Miller <da...@davemloft.net>
>>
>> Upstream: 982b5270 ("openvswitch: Fix mask generation for nested
>> attributes.")
>> Signed-off-by: Jesse Gross <je...@nicira.com>
>
> LGTM
> Acked-by: Pravin B Shelar <pshe...@nicira.com>
Thanks, applied to master. I also did master only on this one since it
is primarily about backwards compatibility with old userspaces and
that shouldn't really be an issue if userspace and kernel are paired.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
