On Wed, Aug 26, 2015 at 01:04:24PM -0700, Jarno Rajahalme wrote: > > > On Aug 26, 2015, at 12:46 PM, Ben Pfaff <b...@nicira.com> wrote: > > > > On Fri, Aug 21, 2015 at 03:25:22PM -0700, Jarno Rajahalme wrote: > >> Tunnel metadata has grown large since the addition of Geneve options. > >> Copying tunnel metadata for performing a lookup is not necessary. > >> Change recirc_metadata to use a pointer to struct flow_tnl, and only > >> copy the tunnel metadata when needed, and only copy as little of it as > >> possible. > >> > >> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com> > > > > The order of members in struct flow_tnl is now important, so I'd add a > > comment in that structure explaining that. > > > > OK. > > > Which lookups does this speed up? > > This patch removes a large-ish copy from the recirculation context > lookup, which is performed for each recirculated upcall and > revalidation of a recirculating flow.
OK. Can you note that more specifically in the commit message? Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
