On 08/26/2015 10:58 AM, Ben Pfaff wrote: > On Tue, Aug 25, 2015 at 02:11:44PM -0400, Russell Bryant wrote: >> ovn-controller previously required the integration bridge to be >> created before running ovn-controller. This patch makes >> ovn-controller automatically create it if it doesn't already exist. >> >> Signed-off-by: Russell Bryant <rbry...@redhat.com> > > Clang has some complaints: > > ../ovn/controller/ovn-controller.c:306:9: error: variable 'mappings_cfg' is > used > uninitialized whenever 'if' condition is false > [-Werror,-Wsometimes-uninitialized] > if (cfg) { > ^~~ > ../ovn/controller/ovn-controller.c:309:10: note: uninitialized use occurs here > if (!mappings_cfg) { > ^~~~~~~~~~~~ > ../ovn/controller/ovn-controller.c:306:5: note: remove the 'if' if its > condition > is always true > if (cfg) { > ^~~~~~~~~ > ../ovn/controller/ovn-controller.c:302:29: note: initialize the variable > 'mappings_cfg' to silence this warning > const char *mappings_cfg; > ^ > = NULL >
OK, thanks. I'll fix this up. -- Russell Bryant _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev