On Tue, Jul 28, 2015 at 09:42:45PM -0300, Flavio Leitner wrote: > On Tue, Jul 28, 2015 at 03:21:14PM -0700, Ben Pfaff wrote: > > This complies with OpenFlow 1.1 and later. > > > > Found by OFTest. > > OF1.1 specs says on page 42 that weight is only defined for > select groups. > > and on page 23 says that switch must refuse to add the group > entry and must send an error msg with code OFPGMFC_INVALID_GROUP. > > Based on that, the patch looks correct to me. > > Acked-by: Flavio Leitner <f...@sysclose.org>
Thanks Flavio. I guess I failed to run the unit tests for this commit earlier, because it broke lots of them. The situation was more complex than I thought. I posted a v2: http://openvswitch.org/pipermail/dev/2015-July/058227.html _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev