Thx for the review, adopt the suggestion,
applied to branch2.3, 2.4, master~
On Tue, Jul 28, 2015 at 8:06 AM, Ben Pfaff <b...@nicira.com> wrote:
> On Mon, Jul 27, 2015 at 11:56:28PM -0700, Alex Wang wrote:
> > Currently the netdev_linux_notify_sock only joins multicast group
> > RTNLGRP_LINK for link status change notification. Some ovs features
> > also require the detection of ip addresses changes and update of the
> > netdev-linux's cache. To achieve this, we need to make
> > netdev_linux_notify_sock join the multicast group RTNLGRP_IPV4_IFADDR
> > and RTNLGRP_IPV6_IFADDR.
> >
> > Signed-off-by: Alex Wang <al...@nicira.com>
> > ---
> > PATCH->V2:
> > - rebase on top of rtnetlink module extension.
>
> ...
>
> > + } else if (rtnetlink_type_is_rtnlgrp_addr(change->nlmsg_type)) {
> > + /* Invalidates in4, in6. */
> > + netdev_linux_changed(dev, dev->ifi_flags,
> > + ~VALID_IN4 ^ VALID_IN6);
>
> This would be more conventionally written ~(VALID_IN4 | VALID_IN6).
>
> Acked-by: Ben Pfaff <b...@nicira.com>
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
