Hi Ben, Thanks for the review.
All the comments have been incorporated in Version 2 of the patch. Thanks Niti Rohilla On Tue, Jul 28, 2015 at 1:23 AM, Ben Pfaff <b...@nicira.com> wrote: > On Thu, Jul 23, 2015 at 05:06:36PM +0530, niti1...@gmail.com wrote: > > From: Niti Rohilla <niti.rohi...@tcs.com> > > > > This patch adds support for Openflow1.4 Group & meter change notification > > messages. In a multi controller environment, when a controller modifies > the > > state of group and meter table, the request that successfully modifies > this > > state is forwarded to other controllers. Other controllers are informed > with > > the OFPT_REQUESTFORWARD message. Request forwarding is enabled on a per > > controller channel basis using the Set Asynchronous Configuration > Message. > > > > Signed-off-by: Niti Rohilla <niti.rohi...@tcs.com> > > Thank you for working on this. I have some comments. > > ofp_print_requestforward() will abort the program if a received > OFPT_REQUESTFORWARD message contains any message other than a group mod > or a meter mod. That's not acceptable. > > In ofputil_encode_requestforward(), for efficiency, the final argument > to ofpraw_alloc_xid() should be the length of 'rf'. > > The message inside OFPT_REQUESTFORWARD needs to have the same OpenFlow > version as the wrapper. ofputil_decode_requestforward() should check > that, and report an error if it differs. It also means > ofputil_encode_requestforward() doesn't need a protocol version > parameter (since it can be inferred from 'rf') and that > connmgr_send_requestforward() needs to somehow make the inner message > compatible with 'ofconn'. I think that probably has to be done by > re-encoding the inner message for the protocol in use on each 'ofconn'. > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
