On 07/16/2015 07:56 PM, Ben Pfaff wrote:
> On Thu, Jul 16, 2015 at 04:55:11PM -0700, Ben Pfaff wrote:
>> On Thu, Jul 16, 2015 at 06:06:10PM -0400, Russell Bryant wrote:
>>> Add a new OVN configuration entry in the Open_vSwitch database called
>>> "ovn-bridge-mappings".  This allows the configuration of mappings
>>> between a physical network name and an OVS bridge that provides
>>> connectivity to that network.
>>>
>>> For example, if you wanted to configure "physnet1" to map to "br-eth0"
>>> and "physnet2" to map to "br-eth1", the configuration would be:
>>>
>>>   $ ovs-vsctl set open . \
>>>   > external-ids:ovn-bridge-mappings=physnet1:br-eth0,physnet2:br-eth1
>>>
>>> In this patch, the configuration option is only parsed and validated
>>> to make sure the referenced bridges actually exist.  Later patches
>>> will make use of the bridge mappings.
>>>
>>> Signed-off-by: Russell Bryant <rbry...@redhat.com>
>>
>> Do later patches add documentation?  That will be important.
>>
>> I wonder whether we should document the ovn configuration external-ids
>> in vswitch.xml, or whether that would indicate too intimate a
>> relationship between OVN and OVS.x
> 
> Oh, also it doesn't compile:
> 
> ../ovn/controller/ovn-controller.c:118:13: error: undefined identifier 
> 'create_patch_ports'
> ../ovn/controller/ovn-controller.c: In function ‘parse_bridge_mappings’:
> ../ovn/controller/ovn-controller.c:118:9: error: implicit declaration of 
> function ‘create_patch_ports’ [-Werror=implicit-function-declaration]
> 

Oops ... I've done a bunch of rebasing, cherry-picks, etc ... I can fix
this up next time around.

-- 
Russell Bryant
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to